piiswrong commented on a change in pull request #10970: [MXNET-424] dtype
option for multinomial
URL: https://github.com/apache/incubator-mxnet/pull/10970#discussion_r191885873
##########
File path: src/operator/random/sample_multinomial_op.h
##########
@@ -67,6 +70,10 @@ inline bool SampleMultinomialOpShape(const nnvm::NodeAttrs&
attrs,
const TShape& ishape = (*in_attrs)[0];
if (!ishape.ndim()) return false;
+ MSHADOW_TYPE_SWITCH(param.dtype, DType, {
+ CHECK_LE(ishape[ishape.ndim() - 1],
mxnet::common::MaxIntegerValue<DType>());
Review comment:
Need to output a message saying why it failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
