eric-haibin-lin commented on a change in pull request #11021: [MXNET-380]
count_include_pad argument for Avg Pooling
URL: https://github.com/apache/incubator-mxnet/pull/11021#discussion_r194194466
##########
File path: src/operator/nn/pooling-inl.h
##########
@@ -81,7 +82,13 @@ struct PoolingParam : public dmlc::Parameter<PoolingParam> {
.describe("Pad for pooling: (y, x) or (d, y, x). Defaults to no padding.");
DMLC_DECLARE_FIELD(p_value).set_default(dmlc::optional<int>())
- .describe("Value of p for Lp pooling, can be 1 or 2, required for Lp
Pooling");
+ .describe("Value of p for Lp pooling, can be 1 or 2, required for Lp
Pooling.");
+
+ DMLC_DECLARE_FIELD(count_include_pad).set_default(dmlc::optional<bool>())
+ .describe("Only used for AvgPool, specify whether to count padding
elements for average"
Review comment:
The argument is optional. Is the default value True or False?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
