anirudh2290 commented on a change in pull request #11212: cherry-pick bug fixes in MKLDNN for v1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/11212#discussion_r194913920
########## File path: tests/cpp/operator/mkldnn.cc ########## @@ -81,13 +81,6 @@ TEST(MKLDNN_UTIL_FUNC, AlignMem) { #endif } -TEST(MKLDNN_UTIL_FUNC, MemFormat) { - // Check whether the number of format is correct. - CHECK_EQ(mkldnn_format_last, 56); - CHECK_EQ(mkldnn_nchw, 5); - CHECK_EQ(mkldnn_oihw, 12); Review comment: why are these unnecessary tests and how are they running on master ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services