marcoabreu commented on a change in pull request #10827: [MXNET-405][WIP] Add 2 
new pipelines to the Official CI and run nightly tests. 
URL: https://github.com/apache/incubator-mxnet/pull/10827#discussion_r195540544
 
 

 ##########
 File path: ci/docker/Dockerfile.build.ubuntu_emscripten
 ##########
 @@ -0,0 +1,58 @@
+# -*- mode: dockerfile -*-
 
 Review comment:
   I know thumbs up means done, but you didn't change anything here ._.
   
   Please reduce the installed dependencies here. You might also want to add 
install/ubuntu_emscripten.sh to the regular dockerfiles we have - or make a 
second pair specifically for nightly and add it there. There are three options, 
pick whichever you prefer :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to