piiswrong commented on a change in pull request #11027: Add standard ResNet
data augmentation for ImageRecordIter
URL: https://github.com/apache/incubator-mxnet/pull/11027#discussion_r196255546
##########
File path: example/image-classification/common/data.py
##########
@@ -43,18 +43,20 @@ def add_data_args(parser):
def add_data_aug_args(parser):
aug = parser.add_argument_group(
'Image augmentations', 'implemented in src/io/image_aug_default.cc')
- aug.add_argument('--random-crop', type=int, default=1,
+ aug.add_argument('--random-crop', type=int, default=0,
help='if or not randomly crop the image')
- aug.add_argument('--random-mirror', type=int, default=1,
+ aug.add_argument('--random-mirror', type=int, default=0,
help='if or not randomly flip horizontally')
aug.add_argument('--max-random-h', type=int, default=0,
help='max change of hue, whose range is [0, 180]')
aug.add_argument('--max-random-s', type=int, default=0,
help='max change of saturation, whose range is [0, 255]')
aug.add_argument('--max-random-l', type=int, default=0,
help='max change of intensity, whose range is [0, 255]')
- aug.add_argument('--max-random-aspect-ratio', type=float, default=0,
- help='max change of aspect ratio, whose range is [0, 1]')
+ aug.add_argument('--min-random-aspect-ratio', type=float, default=1,
+ help='min value of aspect ratio, whose value should be
positive.')
+ aug.add_argument('--max-random-aspect-ratio', type=float, default=1,
Review comment:
should the default be max-random-aspect-ratio = 0 and
min-random-aspect-ratio = None so that we don't break previous API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
