gigasquid commented on issue #11205: Clojure Contrib Package URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-399579788 @larroy and @yzhliu - Thanks. Please let me know if there is anything I can do to help the review and get this merged. I've been trying to keep this PR in sync in the external github repo with other's contributions and generally improving the test coverage, but I can stop adding commits and freeze it to give you a stable PR to review and merge, if that helps. Just let me know. To recap the work and status of the PR so far: - It has been reviewed by @kovasb - who is experienced in both Clojure and Deep Learning - The feedback from your review, @larroy, has been implemented - A code coverage plugin has been integrated - A few bug fix contributions have been brought over from the main repo - The scala jar version has been bumped to `1.2.1` (from using the staging jars) - Additional unit tests have been added to increase coverage. The current stats are: ``` |-----------------------------------------+---------+---------| | Namespace | % Forms | % Lines | |-----------------------------------------+---------+---------| | dev.generator | 93.07 | 94.33 | | org.apache.clojure-mxnet.base | 100.00 | 100.00 | | org.apache.clojure-mxnet.callback | 100.00 | 100.00 | | org.apache.clojure-mxnet.context | 76.00 | 85.71 | | org.apache.clojure-mxnet.dtype | 100.00 | 100.00 | | org.apache.clojure-mxnet.eval-metric | 95.00 | 100.00 | | org.apache.clojure-mxnet.executor | 89.66 | 95.00 | | org.apache.clojure-mxnet.initializer | 25.00 | 43.75 | | org.apache.clojure-mxnet.io | 71.71 | 80.00 | | org.apache.clojure-mxnet.kvstore | 82.91 | 76.00 | | org.apache.clojure-mxnet.kvstore-server | 58.73 | 50.00 | | org.apache.clojure-mxnet.lr-scheduler | 22.22 | 66.67 | | org.apache.clojure-mxnet.module | 74.99 | 88.62 | | org.apache.clojure-mxnet.monitor | 100.00 | 100.00 | | org.apache.clojure-mxnet.ndarray | 90.86 | 91.38 | | org.apache.clojure-mxnet.optimizer | 91.21 | 88.24 | | org.apache.clojure-mxnet.profiler | 20.00 | 40.00 | | org.apache.clojure-mxnet.random | 100.00 | 100.00 | | org.apache.clojure-mxnet.shape | 94.44 | 90.00 | | org.apache.clojure-mxnet.symbol | 48.87 | 54.62 | | org.apache.clojure-mxnet.util | 98.86 | 99.16 | | org.apache.clojure-mxnet.visualization | 6.82 | 20.00 | |-----------------------------------------+---------+---------| | ALL FILES | 80.01 | 84.14 | |-----------------------------------------+---------+---------| ``` I feel the tests are pretty stable, so if you want to add a clojure stage to the CI pipeline, it would be great. All that should be needed is to be able to run the build/test tool `lein` (https://leiningen.org/). To be specific: `cd contrib/clojure-package` `lein test` It would be great to get this merged so that other people can start getting involved and helping to grow and improve the package. 😸
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
