szha commented on a change in pull request #11672: Some Python 3 fixes in ./tools URL: https://github.com/apache/incubator-mxnet/pull/11672#discussion_r202419956
########## File path: tools/accnn/rank_selection.py ########## @@ -16,12 +16,14 @@ # under the License. import numpy as np -import mxnet as mx import json import utils import math import sys +from mxnet.base import xrange Review comment: Why? We don't have xrange definition in mxnet.base. My approval doesn't apply to this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
