eric-haibin-lin commented on a change in pull request #11995: Remove fixed seed
for test_l1_loss and test_l2_loss
URL: https://github.com/apache/incubator-mxnet/pull/11995#discussion_r207601830
##########
File path: tests/python/unittest/test_loss.py
##########
@@ -144,7 +144,7 @@ def test_kl_loss():
assert mod.score(data_iter, eval_metric=mx.metric.Loss())[0][1] < 0.05
-@with_seed(1234)
+@with_seed()
Review comment:
There was no report of flakiness on this test (no failures as far as I
know). Using the same comment you sent is confusing. I can add a line
referencing the Github issue in the test, although developers can always track
changes via git blame, and the issue is referenced in the PR. I don't see it as
a common practice to mention all Github issue number every time a test is
updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
