yzhliu commented on a change in pull request #11844: [MXNET-689] add DataDesc
type for the Scala Package
URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210066179
##########
File path:
scala-package/core/src/main/scala/org/apache/mxnet/io/NDArrayIter.scala
##########
@@ -285,12 +317,37 @@ object NDArrayIter {
this
}
+ /**
+ * Set the dtype.
+ * @param dataDType The dtype of the data, default is Float32
+ * @param labelDType The dtype of the label, default is Int32
+ * @return this
+ */
+ def setDType(dataDType: DType, labelDType: DType): Builder = {
Review comment:
suggest to separate `setDataDtype` and `setLabelDtype`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
