nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc
type for the Scala Package
URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210421479
##########
File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala
##########
@@ -136,11 +139,25 @@ class DataBatch(val data: IndexedSeq[NDArray],
val pad: Int,
// the key for the bucket that should be used for this batch,
// for bucketing io only
- val bucketKey: AnyRef = null,
- // use ListMap to indicate the order of data/label loading
+ val bucketKey: AnyRef,
+ // use DataDesc to indicate the order of data/label loading
// (must match the order of input data/label)
- private val providedData: ListMap[String, Shape] = null,
- private val providedLabel: ListMap[String, Shape] = null) {
+ private val providedDataDesc: IndexedSeq[DataDesc],
Review comment:
Don't you want to do the same as Andrew suggested to keep the `NDArray` and
`DataDesc` together here as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
