haojin2 commented on a change in pull request #11836: Support kAddTo for
softmax backward
URL: https://github.com/apache/incubator-mxnet/pull/11836#discussion_r211471785
##########
File path: src/operator/contrib/ctc_loss-inl.h
##########
@@ -426,7 +426,7 @@ class CTCLossOp : public Operator {
workspace_bytes));
if (req_grad) {
- mxnet_op::SoftmaxGrad<mshadow_op::mul, mxnet_op::softmax_bwd>(s,
+ mxnet_op::SoftmaxGrad<mshadow_op::mul, mxnet_op::softmax_bwd,
kWriteTo>(s,
Review comment:
It's not within the scope of this PR, this PR is purely for fixing the
problem with the request type the backward of softmax can handle. I can
probably take a look into the problem later though, but I think this PR should
be good to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
