szha commented on a change in pull request #12209: Make the output format of
control flow operators consistent with their UDFs
URL: https://github.com/apache/incubator-mxnet/pull/12209#discussion_r212043020
##########
File path: python/mxnet/symbol/contrib.py
##########
@@ -366,7 +389,8 @@ def while_loop(cond, func, loop_vars, max_iterations=None,
name="while_loop"):
Also, `new_loop_vars` should contain the same number of elements as
`loop_vars`,
and the corresponding element should have the same shape and dtype.
The `func` is variadic, and its signature should be
- `func(*loop_vars) => (List[Symbol] step_output, List[Symbol]
new_loop_vars)`.
+ `func(*loop_vars) =>
+ (Symbol or List[Symbol] step_output, Symbol or List[Symbol]
new_loop_vars)`.
Review comment:
I believe now this allows nested symbol?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
