sandeep-krishnamurthy commented on a change in pull request #12376: [MXNET-854] SVRG Optimization in Python Module API URL: https://github.com/apache/incubator-mxnet/pull/12376#discussion_r213414138
########## File path: contrib/svrg_optimization_python/test_svrg_train.py ########## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: tests should go tests. May be like below? 1. tests/python/train/test_contrib_svrg.py : Full end to end train and testing. See test_mlp.py as an example. Please, note, it should be faster (< 2 min at max?). If it is longer than that, we need to move it to nightly test. 2. tests/python/unittest/test_contrib_svrgmodule.py / ..._svrgoptimizer.py etc.. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
