StephanieYuan commented on a change in pull request #12376: [MXNET-854] SVRG Optimization in Python Module API URL: https://github.com/apache/incubator-mxnet/pull/12376#discussion_r213422213
########## File path: contrib/svrg_optimization_python/src/svrg_optimizer.py ########## @@ -0,0 +1,131 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""A `SVRGOptimizer` encapsulates two optimizers to accommodate SVRG optimization logic. +""" + + +import mxnet as mx + + +@mx.optimizer.register +class AssignmentOptimizer(mx.optimizer.Optimizer): + def update(self, index, weight, grad, state): + weight[:] = grad + +@mx.optimizer.register +class SVRGOptimizer(mx.optimizer.Optimizer): + """SVRGOptimizer is a wrapper class for two optimizers: one for accumulating full gradients and the other Review comment: For the previous benchmarks SVRG is used with SGD, I did some exploration of using NAG + SVRG and Adam + SVRG. I think it will be valuable to benchmark those optimizers with SVRG too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
