haojin2 opened a new pull request #12306: SoftMin Operator URL: https://github.com/apache/incubator-mxnet/pull/12306 ## Description ## Support softmin function: https://pytorch.org/docs/master/_modules/torch/nn/functional.html#softmin ## Checklist ## ### Essentials ### - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [x] Softmin operator - [x] Corresponding unit tests ## Comments ## Passed more than 10000 trials on both CPU & GPU: ``` MXNET_TEST_COUNT=10000 nosetests -s --verbose tests/python/unittest/test_operator.py:test_softmin [INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=53121875 to reproduce. test_operator.test_softmin ... ok ---------------------------------------------------------------------- Ran 1 test in 670.955s OK ``` ``` MXNET_TEST_COUNT=10000 nosetests -s --verbose tests/python/gpu/test_operator_gpu.py:test_softmin [INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=207344053 to reproduce. test_operator_gpu.test_softmin ... ok ---------------------------------------------------------------------- Ran 1 test in 946.723s OK ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
