terrytangyuan commented on issue #12162: Edit shape.array doc and some style improvements URL: https://github.com/apache/incubator-mxnet/pull/12162#issuecomment-416758686 I believe that should be done in a separate PR. I doubt that `formatR` gives the most readable code, e.g. I've rarely seen the following style but it appears to be on the PR you referred to: ``` convolution_module <- function(net, kernel_size, pad_size, filter_count, stride = c(1, 1), work_space = 2048, batch_norm = TRUE, down_pool = FALSE, up_pool = FALSE, ``` or ``` if (Sys.getenv("R_GPU_ENABLE") != "" & as.integer(Sys.getenv("R_GPU_ENABLE")) == 1) { ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
