gigasquid opened a new pull request #12387: MXNET-873 - Bring Clojure Package inline with new DataDesc and Layout in Scala Package URL: https://github.com/apache/incubator-mxnet/pull/12387 ## Description ## The Scala package has updated the DataDesc to include Layout. The Clojure package has been updated to move inline with it. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [X] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [X] Changes are complete (i.e. I finished coding on this PR) - [X] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [X] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - A layout namespace has been created and used in DataDesc - The Clojure package no longer infers the layout from the shape. It handles it the same way as the Scala package by having it be undefined - The original `module.fit` interop code has been restored. The work arounds required by the old DataDesc has been resolved with this PR https://github.com/apache/incubator-mxnet/pull/11844 - Most of the examples have moved to use `provide-data-desc` instead of `provide-data` - Formatting fixes - Tweak to Char RNN example to run for less epochs before showing the pre-loaded result
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
