marcoabreu commented on a change in pull request #11952: [MXNET-707] Add unit
test for mxnet to coreml converter
URL: https://github.com/apache/incubator-mxnet/pull/11952#discussion_r223527417
##########
File path: ci/travis/install.sh
##########
@@ -22,5 +22,5 @@ export HOMEBREW_NO_AUTO_UPDATE=1
if [ ${TRAVIS_OS_NAME} == "osx" ]; then
brew install opencv
- python -m pip install --user nose numpy cython scipy requests mock
nose-timer nose-exclude
+ python -m pip install --user nose numpy cython scipy requests mock
nose-timer nose-exclude mxnet-to-coreml
Review comment:
The problem is that a PR to update the core ml converter might introduce a
bug because we are not actually validating the package but rather the released
package. Since the package is under our control and the purpose is to validate
it, we should use the source package as source instead of the released package.
Otherwise, we will have all PRs and pipelines suddenly dial as soon as we
publish a new release of the converter. I don't think that's the right flow for
a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
