safrooze commented on a change in pull request #13390: Onnx multi output
URL: https://github.com/apache/incubator-mxnet/pull/13390#discussion_r236114975
##########
File path: tests/python-pytest/onnx/export/mxnet_export_test.py
##########
@@ -238,6 +241,79 @@ def test_square():
npt.assert_almost_equal(result, numpy_op)
+
+def _assert_sym_equal(lhs, rhs):
+ assert lhs.list_inputs() == rhs.list_inputs() # input names must be
identical
+ assert len(lhs.list_outputs()) == len(rhs.list_outputs()) # number of
outputs must be identical
Review comment:
I thought that's unnecessary given the test in _check_onnx_export() which
sends random data into the original network and into imported network and makes
sure outputs are equal. That includes shape and values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
