apeforest commented on a change in pull request #12866: Optimization for
embedding OP for CPU
URL: https://github.com/apache/incubator-mxnet/pull/12866#discussion_r235567700
##########
File path: src/operator/tensor/indexing_op.cc
##########
@@ -61,10 +61,14 @@ template<typename DType>
bool CheckIndexOutOfBound(const DType* data_ptr, size_t data_size,
const DType min, const DType max) {
bool is_valid = true;
- for (size_t i = 0; i < data_size; i++) {
+ // to avoid Jenkins omp check error
+ int64_t size = data_size;
+ int64_t check_block_size = dmlc::GetEnv("MXNET_CPU_PARALLEL_CHECK_SIZE",
14000);
Review comment:
Magic number 14000? Please add reference
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
