stu1130 commented on a change in pull request #13496: Optimize C++ API
URL: https://github.com/apache/incubator-mxnet/pull/13496#discussion_r238894857
##########
File path: cpp-package/example/utils.h
##########
@@ -42,7 +42,7 @@ bool check_datafiles(const std::vector<std::string>
&data_files) {
return true;
}
-bool setDataIter(MXDataIter *iter , std::string useType,
+bool setDataIter(MXDataIter *iter , const std::string &useType,
const std::vector<std::string> &data_files, int batch_size) {
Review comment:
```suggestion
const std::vector<std::string> &data_files, const int
batch_size) {
```
nit: could this be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
