ZhennanQin commented on a change in pull request #12980: Add reshape op 
supported by MKL-DNN
URL: https://github.com/apache/incubator-mxnet/pull/12980#discussion_r238931461
 
 

 ##########
 File path: src/operator/tensor/matrix_op.cc
 ##########
 @@ -261,7 +317,9 @@ Example::
 .set_num_outputs(1)
 .set_attr<nnvm::FInferShape>("FInferShape", FlattenShape)
 .set_attr<nnvm::FInferType>("FInferType", ElemwiseType<1, 1>)
+#if MXNET_USE_MKLDNN == 1
 
 Review comment:
   If MKLDNN supports this op, please add `.set_attr<bool>("TIsMKLDNN", true)` 
for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to