eric-haibin-lin opened a new pull request #13742: Reorder module import orders 
for dist-kvstore
URL: https://github.com/apache/incubator-mxnet/pull/13742
 
 
   ## Description ##
   For distributed training, a new process is launched when importing the 
`kvstore_server` module. This should be imported at last so that other MXNet 
modules are initialized correctly. Otherwise this may result in error when 
unpickling custom LR scheduler/optimizers. For example, the LRScheduler in 
gluoncv 
https://github.com/dmlc/gluon-cv/blob/master/gluoncv/utils/lr_scheduler.py#L8 
depends on a specific version of MXNet, and checks the `__version__` attr of 
MXNet, which is not set on kvstore server due to the fact that kvstore-server 
module is imported before the `__version__` attr is set. 
   
   @hetong007 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   End to end tested with a gluon-cv example. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to