stephenrawls commented on issue #13956: C API should *never* call abort()
URL: 
https://github.com/apache/incubator-mxnet/issues/13956#issuecomment-457984886
 
 
   Good catch, sorry for the confusion. Can't speak for @mika-fischer, but as 
for me, I dug through the various layers until I saw `abort()` in the code and 
didn't pay close enough attention to the #if/#elif preprocessor declarations.
   
   My other complaint about the c++ api is that it doesn't always check the 
return status of its C API calls. But that issue is much easier to detect and 
fix, I will put in a separate Issue / Pull Request about that.  (e.g. see here: 
https://github.com/apache/incubator-mxnet/blob/master/cpp-package/include/mxnet-cpp/operator.hpp#L137-L139)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to