KellenSunderland commented on a change in pull request #14040: Reformat of 
TensorRT to use subgraph API
URL: https://github.com/apache/incubator-mxnet/pull/14040#discussion_r253288021
 
 

 ##########
 File path: include/mxnet/c_api.h
 ##########
 @@ -1835,12 +1835,6 @@ MXNET_DLL int MXExecutorReshape(int partial_shaping,
                                 ExecutorHandle shared_exec,
                                 ExecutorHandle *out);
 
-/*!
- * \brief get optimized graph from graph executor
- */
-MXNET_DLL int MXExecutorGetOptimizedSymbol(ExecutorHandle handle,
-                                           SymbolHandle *out);
-
 
 Review comment:
   It affect semantic versioning if we remove it (it can break compilation on 
downstream projects) so if there's not a strong reason to remove it we should 
leave it in for that reason.  Can it still preform a useful function (for 
example showing the graph after optimization)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to