zhreshold commented on a change in pull request #14031: Fix transposed convolution in CPU w/o MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/14031#discussion_r253289470
########## File path: tests/python/unittest/test_gluon.py ########## @@ -503,6 +503,40 @@ def test_deconv(): # layer = nn.Conv3DTranspose(16, (3, 3, 3), layout='NDHWC', in_channels=4) # # check_layer_forward(layer, (1, 10, 10, 10, 4)) +@with_seed() +def test_deconv_dilation(): Review comment: Since deconv is a really important OP, I suggest to visit the original deconv test cases and add dilation > 1 cases alongside the old tests. This ensures better coverage than this single test case. Feel free to keep this unittest which LGTM as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services