DickJC123 commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r254099481
########## File path: tests/python/gpu/test_operator_gpu.py ########## @@ -608,6 +608,72 @@ def test_convolution_versions(): @with_seed() +def test_pooling_with_convention(): Review comment: As part of finalizing this PR, I greatly expanded the coverage of test_pooling_versions(), to the point where it basically repeats the test cases covered here. In response to your comment, I expanded test_pooling_versions() to include some new subtleties (like whether default parameters are explicitly passed or not) to match what was done in test_pooling_with_convention(). Given that, I'm now removing test_pooling_with_convention(). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
