vandanavk commented on a change in pull request #13955: adding the gluon 
implementation of deformable convolution
URL: https://github.com/apache/incubator-mxnet/pull/13955#discussion_r254101937
 
 

 ##########
 File path: tests/python/unittest/test_gluon_contrib.py
 ##########
 @@ -228,6 +228,30 @@ def test_sampler():
     assert list(interval_sampler) == [0, 3, 6, 9]
 
 
+def test_deformable_convolution():
+    net = nn.HybridSequential()
+    net.add(
+        Deformable_Convolution(10, kernel_size=(3, 3), strides=1, padding=0),
+        Deformable_Convolution(10, kernel_size=(3, 2), strides=1, padding=0, 
activation='relu',
+                               offset_use_bias=False, use_bias=False)
 
 Review comment:
   could you add tests for all possible combinations of arguments?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to