larroy commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-461105625 I'm not an expert in cython but the changes look sane. I think we can merge this at least tentatively and observe. Since the author did some benchmarking and there are gains we need to keep an eye on performance numbers. I would be in favor of merging and if there's unexpected ramifications we can revert.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
