zheng-da commented on a change in pull request #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#discussion_r254941634
########## File path: src/operator/contrib/ngraph-inl.h ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * Copyright (c) 2018 Intel Corporation + * \file ngraph.cc + * \brief ngraph subgraph property for mxnet +*/ + +#ifndef MXNET_OPERATOR_CONTRIB_NGRAPH_INL_H_ +#define MXNET_OPERATOR_CONTRIB_NGRAPH_INL_H_ + +#if MXNET_USE_NGRAPH +#include <ngraph_compiler.h> +#include <ngraph_imperative.h> +#include <ngraph_nnvm_ops.h> +#include <ngraph_utils.h> + +#include <vector> + +#include "../subgraph/common.h" +#include "../subgraph/subgraph_property.h" + +namespace mxnet { +namespace op { + +// when built with NGRAPH we use this subgraph by default +static int ngraph_backend = setenv("MXNET_SUBGRAPH_BACKEND", "ngraph", 0); Review comment: to be honest, I still feel this is not a good idea to make ngraph a default backend when ngraph is built in mxnet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
