gordon1992 opened a new pull request #14000: MXNET-1302 Exclude commons-codec 
and commons-io from assembled JAR
URL: https://github.com/apache/incubator-mxnet/pull/14000
 
 
   Consumers of MXNet are exposed to the commons-codec and commons-io library 
versions MXNet uses internally. This change excludes those JARs from the JARs 
created with `make scalapkg`.
   
   ## Description ##
   This PR removes commons-codec and commons-io from the assembled JAR and adds 
both packages as dependencies in deploy.xml
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA 
issue](https://issues.apache.org/jira/projects/MXNET/issues/MXNET-1302) created 
(except PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] commons-io and commons-codec remove from assembled JAR
   - [x] commons-io and commons-codec added as dependencies to deploy.xml
   
   ## Comments ##
   My Maven knowledge is sparse so I may have missed something.
   
   For testing:
   * The JAR no longer contains org.apache.commons classes
   * make scalapkg && make scalaunittests && make scalaintegrationtests passed 
on my Ubuntu 18.04 machine (JDK 8).
   
   Originally reported in #13929 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to