ZhennanQin commented on issue #14123: Add int8 data loader URL: https://github.com/apache/incubator-mxnet/pull/14123#issuecomment-465461034 @anirudh2290 No need to apologies, you're one of the most active reviewers I've seen in MXNet project:) The patch letting quantize_v2 accept int8 is ready at https://github.com/ZhennanQin/incubator-mxnet/pull/5. You can apply it based on this PR. Alternately, you can pick whole patch with int8 data loader at https://github.com/ZhennanQin/incubator-mxnet/pull/6. `I couldnt find a way to save state in InferType to reuse it within function registered for Inplace optimization.` Yes, that's the major problem when apply inplace optimization. But luckily, there's a strict dtype check in memory planning pass, that allows memory inplace happen only when input and output has same dtype. So registering FInplaceOption and FInplaceIdentity to quantize_v2 is enough.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
