ZhennanQin commented on a change in pull request #14123: Add int8 data loader
URL: https://github.com/apache/incubator-mxnet/pull/14123#discussion_r258740094
##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -156,6 +157,10 @@ Graph QuantizeGraph(Graph &&src) {
if (avoid_quantize_input_map.count(node->op()) &&
avoid_quantize_input_map[node->op()](node->attrs, i)) {
new_node->inputs.emplace_back(mirror_entry);
+ // If network will directly accept quantized data, simply add data as
input.
+ } else if (use_quantized_data_layer && e.node->is_variable() &&
+ e.node->attrs.name == "data") {
Review comment:
Agree, this can be removed if quantize_v2 can directly accept int8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
