eric-haibin-lin commented on a change in pull request #14153: Fix shape inference pass URL: https://github.com/apache/incubator-mxnet/pull/14153#discussion_r259634912
########## File path: src/executor/infer_graph_attr_pass.cc ########## @@ -68,8 +68,28 @@ bool ApplyOpInferAttr<int, FInferStorageType>(const nnvm::Graph& g, * shape/type inference functions'. The nnvm InferAttr will be deprecated * in the future. Please use interfaces InferShape, InferType, and InferStorageType * to call this function. + * + * \param ret graph used for attribute inference + * \param emmpty_val empty value of the attribute + * \param infer_name name of the function used for attribute inference + * \param input_name name of the attribute in the graph used to store the + * input data for attribute inference + * \param attr_key_name name of the attribute used for inference for variable nodes + * \param attr_name name of the inferred attribute + * \param unknown_name name of the attribute storing number of entries + * impossible to infer + * \param fis_none function returning true for not fully inferred values + * \param fnum_unknown function returning how many elements are unknown in + * partially inferred value of the attribute + * \param fdefault default function used for inference if the node does not + * provide its own implementation. + * \param scalars_only whether the inferred attribute may be only a scalar + * \param bwd_identity_assign TODO + * \param dispatch_mode_name TODO Review comment: Name of the dispatch mode attribute on the node. Used for storage type inference. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
