ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261481627
########## File path: src/operator/nn/mkldnn/mkldnn_fully_connected-inl.h ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file mkldnn_fully_connected-inl.h + * \brief + * \author +*/ + +#ifndef MXNET_OPERATOR_NN_MKLDNN_MKLDNN_FULLY_CONNECTED_INL_H_ +#define MXNET_OPERATOR_NN_MKLDNN_MKLDNN_FULLY_CONNECTED_INL_H_ + +#if MXNET_USE_MKLDNN == 1 + +#include <vector> +#include <string> +#include "../fully_connected-inl.h" +#include "./mkldnn_base-inl.h" + +namespace mxnet { +namespace op { + +struct MKLDNNFCParam: public dmlc::Parameter<MKLDNNFCParam> { + bool quantized; + bool fuse_requantize; Review comment: This param was added to on pair with `fuse_dequantize`, but indeed this can be replaced by checking `min/max_calib_range`. I will remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
