wkcn commented on a change in pull request #14363: Support multi-threading for Custom Operator URL: https://github.com/apache/incubator-mxnet/pull/14363#discussion_r263666113
########## File path: src/operator/custom/custom-inl.h ########## @@ -139,38 +142,52 @@ class CustomOperator { destructing_ = true; cv_.notify_all(); } - worker_.join(); + for (auto &worker : workers_) + worker.join(); } static CustomOperator* Get(); private: - CustomOperator() { + CustomOperator() : num_free_threads(0) { destructing_ = false; naive_engine_ = true; if (std::string("NaiveEngine") != dmlc::GetEnv("MXNET_ENGINE_TYPE", std::string())) { naive_engine_ = false; - worker_ = std::thread( - [&]() { - std::unique_lock<std::mutex> lock(mutex_); - while (!q_.empty() || !destructing_) { - cv_.wait(lock, [&] {return !q_.empty() || destructing_;}); - while (!q_.empty()) { - auto fn = q_.front(); - lock.unlock(); - fn(); - lock.lock(); - q_.pop(); - } - } - }); + SetNumThreads(1); + } + } + void ThreadTarget() { + std::unique_lock<std::mutex> lock(mutex_); + while (!q_.empty() || !destructing_) { + cv_.wait(lock, [&] {return !q_.empty() || destructing_;}); + while (!q_.empty()) { + --num_free_threads; + auto fn = q_.front(); + q_.pop(); + lock.unlock(); + fn(); + ++num_free_threads; + lock.lock(); + } + } + } + void SetNumThreads(int num_threads) { + num_threads = std::min(dmlc::GetEnv("MXNET_CUSTOM_OP_NUM_THREADS", 16), num_threads); Review comment: MXNET_CUSTOM_OP_NUM_THREADS is the maximum number of threads for custom operator. When threads are not enough, it will create new threads until the number of threads reaches MXNET_CUSTOM_OP_NUM_THREADS. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services