szha commented on a change in pull request #14377: Correct update count with 
Gluon trainer and update_on_kvstore=False
URL: https://github.com/apache/incubator-mxnet/pull/14377#discussion_r265376237
 
 

 ##########
 File path: python/mxnet/optimizer/optimizer.py
 ##########
 @@ -380,6 +381,11 @@ def set_wd_mult(self, args_wd_mult):
                     self.wd_mult[name] = float(attr[name]['__wd_mult__'])
         self.wd_mult.update(args_wd_mult)
 
+    def set_current_context(self, ctx):
+        if ctx not in self._all_index_update_counts:
 
 Review comment:
   rename to _set_current_context, and document the type of ctx?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to