wkcn commented on a change in pull request #14313: compatibility with opencv4
URL: https://github.com/apache/incubator-mxnet/pull/14313#discussion_r265384977
 
 

 ##########
 File path: Makefile
 ##########
 @@ -146,11 +146,33 @@ endif
 
 # setup opencv
 ifeq ($(USE_OPENCV), 1)
-       CFLAGS += -DMXNET_USE_OPENCV=1 $(shell pkg-config --cflags opencv)
-       LDFLAGS += $(filter-out -lopencv_ts, $(shell pkg-config --libs opencv))
+       CFLAGS += -DMXNET_USE_OPENCV=1
+       ifneq ($(USE_OPENCV_INC_PATH), NONE)
 
 Review comment:
   @reminisce @szha Hi! I have fixed it in the PR 
https://github.com/apache/incubator-mxnet/pull/14424

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to