szha commented on a change in pull request #14425: Fix crashes on visualization
URL: https://github.com/apache/incubator-mxnet/pull/14425#discussion_r265398504
##########
File path: python/mxnet/visualization.py
##########
@@ -339,11 +339,17 @@ def looks_like_weight(name):
elif op == "BatchNorm":
attr["fillcolor"] = cm[3]
elif op in ('Activation', 'LeakyReLU'):
- label = r"%s\n%s" % (op, node["attrs"]["act_type"])
+ if op == "LeakyReLU":
Review comment:
if special handling is needed for each case, then the outer `elif op in ...`
is not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
