anirudh2290 commented on a change in pull request #14277: Enhance PartitionGraph URL: https://github.com/apache/incubator-mxnet/pull/14277#discussion_r266575864
########## File path: src/operator/subgraph/subgraph_property.h ########## @@ -200,7 +197,7 @@ typedef dmlc::ThreadLocalStore<std::unordered_map<std::string, std::unordered_se #define MXNET_REGISTER_SUBGRAPH_PROPERTY(Name, SubgraphPropertyType) \ static DMLC_ATTRIBUTE_UNUSED auto __make_ ## SubgraphPropertyType ## _ ## Name ## __ = \ - SubgraphPropertyRegistry::Get()->__REGISTER_OR_GET__(#Name, &SubgraphPropertyType::Create) + SubgraphPropertyRegistry::Get()->__REGISTER__(#Name, &SubgraphPropertyType::Create) Review comment: We can have a different macro for registering property versus registering backend. For example: ``` MXNET_REGISTER_SUBGRAPH_PROPERTY(DefaultSubgraphProperty) MXNET_REGISTER_BACKEND(default, DefaultSubgraphProperty, DefaultSubgraphProperty) ``` I don't mind sticking to the limitation of including MXNET_REGISTER_SUBGRAPH_PROPERTY to only from .cc files but we need to document this well otherwise this can lead to difficult to trace bugs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
