eric-haibin-lin commented on a change in pull request #14449: GELU Operator URL: https://github.com/apache/incubator-mxnet/pull/14449#discussion_r266635416
########## File path: src/operator/mshadow_op.h ########## @@ -127,6 +131,20 @@ MXNET_UNARY_MATH_OP(softsign, a / (1.0f + math::fabs(a))); MXNET_UNARY_MATH_OP(softsign_grad, 1.0f / math::sqr(1.0f + math::fabs(a))); +#define gelu_gx(a) \ Review comment: Can we have MXNET_ as the prefix for the macro? thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
