yuxihu commented on a change in pull request #14480: Tidy up storage allocation
and deallocation
URL: https://github.com/apache/incubator-mxnet/pull/14480#discussion_r269301582
##########
File path: src/storage/gpu_device_storage.h
##########
@@ -43,20 +43,24 @@ class GPUDeviceStorage {
public:
/*!
* \brief Allocation.
- * \param size Size to allocate.
- * \return Pointer to the storage.
+ * \param handle Handle struct.
*/
- inline static void* Alloc(Storage::Handle* handle);
+ inline static void Alloc(Storage::Handle* handle);
/*!
* \brief Deallocation.
- * \param ptr Pointer to deallocate.
+ * \param handle Handle struct.
*/
inline static void Free(Storage::Handle handle);
}; // class GPUDeviceStorage
-inline void* GPUDeviceStorage::Alloc(Storage::Handle* handle) {
- const size_t size = handle->size;
+inline void GPUDeviceStorage::Alloc(Storage::Handle* handle) {
void* ret = nullptr;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
