gigasquid commented on a change in pull request #14531: Chouffe/clojure fix
tests
URL: https://github.com/apache/incubator-mxnet/pull/14531#discussion_r270447609
##########
File path: contrib/clojure-package/test/org/apache/clojure_mxnet/util_test.clj
##########
@@ -70,8 +70,8 @@
(util/option->value)))))
(deftest test-keyword->snake-case
- (is (= [:foo-bar :foo2 :bar-bar])
- (util/keyword->snake-case [:foo_bar :foo2 :bar-bar])))
+ (is (= ["foo_bar" "foo2" "bar_bar"]
Review comment:
to test the base functionality. It was one of those cases where the dev
generator was written initially without any tests and then I circled back and
put tests in, so the tests don't make as much sense as if they would have if it
was initially written with that intent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
