larroy commented on a change in pull request #14570: [WIP] use a compile flag
to use int64 tensor size
URL: https://github.com/apache/incubator-mxnet/pull/14570#discussion_r272345438
##########
File path: include/mxnet/tensor_blob.h
##########
@@ -456,7 +456,7 @@ class FieldEntry<mxnet::TShape>
this->enforce_nonzero_ = true;
return this->self();
}
- inline FieldEntry<mxnet::TShape> &set_expect_ndim(mxnet::index_t ndim) {
+ inline FieldEntry<mxnet::TShape> &set_expect_ndim(int ndim) {
Review comment:
I get your point. I'm not convinced that the dimensions type should be
signed, as it makes no sense. Agree that the int width should be enough. I
personally would make it unsigned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
