karan6181 commented on a change in pull request #14587: [MXNET-1344, 1346][FIT API] Retrieve Batch size and Logging verbose support for Gluon fit() API URL: https://github.com/apache/incubator-mxnet/pull/14587#discussion_r272406492
########## File path: python/mxnet/gluon/estimator/estimator.py ########## @@ -241,16 +274,23 @@ def fit(self, train_data, from a data batch and load into contexts(devices) """ - self.epochs = epochs - if not batch_size: - batch_size = 32 * len(self.context) + num_batches, total_samples, batch_size = self._infer_data_info(train_data) + + if isinstance(self.context, list): Review comment: No longer relevant. Modified the designed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services