larroy commented on a change in pull request #14665: [performance] Avoid
uneccesary vector copies in imperative_utils.cc
URL: https://github.com/apache/incubator-mxnet/pull/14665#discussion_r274163045
##########
File path: src/imperative/imperative_utils.cc
##########
@@ -20,62 +20,61 @@
#include "./imperative_utils.h"
#include "./cached_op.h"
-namespace mxnet {
-namespace imperative {
+namespace {
-inline std::vector<NDArray*> NodeInputs(const nnvm::IndexedGraph& idx,
- const int node_idx,
- const std::vector<NDArray*> arrays) {
+std::vector<NDArray*> NodeInputs(const nnvm::IndexedGraph& idx,
Review comment:
This would be unnecessary and non idiomatic. Return value optimization (RVO)
will kick in and eliminate any extra copies on return values.
https://shaharmike.com/cpp/rvo/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
