yuxihu commented on a change in pull request #14615: Add MXEnginePushAsync and
MXEnginePushSync C APIs
URL: https://github.com/apache/incubator-mxnet/pull/14615#discussion_r274738854
##########
File path: include/mxnet/c_api.h
##########
@@ -2541,6 +2553,51 @@ MXNET_DLL int MXNDArrayGetSharedMemHandle(NDArrayHandle
handle, int* shared_pid,
MXNET_DLL int MXNDArrayCreateFromSharedMem(int shared_pid, int shared_id,
const mx_uint *shape,
mx_uint ndim, int dtype,
NDArrayHandle *out);
+/*!
+ * \brief Push an asynchronous operation to the engine.
+ * \param async_func Execution function whici takes a parameter on_complete
+ * that must be called when the execution ompletes.
+ * \param func_param The parameter set on calling async_func, can be NULL.
+ * \param deleter The callback to free func_param, can be NULL.
+ * \param ctx_handle Execution context.
+ * \param const_vars_handle The variables that current operation will use
+ * but not mutate.
+ * \param num_const_vars The number of const_vars.
+ * \param mutable_vars_handle The variables that current operation will
mutate.
+ * \param num_mutable_vars The number of mutable_vars.
+ * \param prop_handle Property of the function.
+ * \param priority Priority of the action, as hint to the engine.
+ * \param opr_name The operation name.
+ * \param wait Whether this is a WaitForVar operation.
+ */
+MXNET_DLL int MXEnginePushAsync(EngineAsyncFunc async_func, void* func_param,
+ EngineFuncParamDeleter deleter, ContextHandle
ctx_handle,
+ EngineVarHandle const_vars_handle, size_t
num_const_vars,
+ EngineVarHandle mutable_vars_handle, size_t
num_mutable_vars,
+ EngineFnPropertyHandle prop_handle = NULL, int
priority = 0,
+ const char* opr_name = NULL, bool wait =
false);
+
+/*!
+ * \brief Push a synchronous operation to the engine.
+ * \param sync_func Execution function that executes the operation.
+ * \param func_param The parameter set on calling sync_func, can be NULL.
+ * \param deleter The callback to free func_param, can be NULL.
+ * \param ctx_handle Execution context.
+ * \param const_vars_handle The variables that current operation will use
+ * but not mutate.
+ * \param num_const_vars The number of const_vars.
+ * \param mutable_vars_handle The variables that current operation will
mutate.
+ * \param num_mutable_vars The number of mutable_vars.
+ * \param prop_handle Property of the function.
+ * \param priority Priority of the action, as hint to the engine.
+ * \param opr_name The operation name.
+ */
+MXNET_DLL int MXEnginePushSync(EngineSyncFunc sync_func, void* func_param,
+ EngineFuncParamDeleter deleter, ContextHandle
ctx_handle,
+ EngineVarHandle const_vars_handle, size_t
num_const_vars,
Review comment:
Let me change to in to be consistent with other C APIs. I will add a check
to make sure non-negative values are used internally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
