roywei commented on a change in pull request #14685: [Fit API] improve event
handlers
URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r276809625
##########
File path: python/mxnet/gluon/contrib/estimator/estimator.py
##########
@@ -57,87 +60,85 @@ def __init__(self, net,
context=None):
self.net = net
+ self.loss = self._check_loss(loss)
+ self.train_metrics = self._check_metrics(metrics)
+
+ # Use default mx.metric.Accuracy() for
gluon.loss.SoftmaxCrossEntropyLoss()
+ if not self.train_metrics and any([isinstance(l,
gluon.loss.SoftmaxCrossEntropyLoss) for l in self.loss]):
Review comment:
@szha Agree, but it Acc as default may not work well for other type of
loss. How about moving this logic to `prepare_loss_and_metrics()`? So the
reference is also returned to user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
