aaronmarkham commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r277073221
########## File path: docs/install/osx_setup.md ########## @@ -146,10 +157,11 @@ We have installed MXNet core library. Next, we will install MXNet interface pack To install the MXNet Python binding navigate to the root of the MXNet folder then run the following: ```bash -$ cd python -$ pip install -e . +virtualenv -p`which python3` py3_venv Review comment: It depends where it's going. When we have a detailed guide, it is fine to add recommended practices as new users may not know these details like a seasoned Python developer might. When we have a very succinct section like the install page, I'd leave out these details. So, I'd leave this in here since osx_setup.md is meant to be a detailed guide. I do suggest another name though. Like `mxnet_p36`, which is used as the names of the Conda environments on the DLAMI. Speaking of Conda, it would be good to mention this as an option too. It's ok to not document those steps as you're providing the virtualenv steps already. It's nice to let people know that mxnet will work fine in a Conda environment if that's what they want to do. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
