eric-haibin-lin commented on a change in pull request #14830: [WIP] Use env var
to enforce safe accumulation in ReduceAxesCompute
URL: https://github.com/apache/incubator-mxnet/pull/14830#discussion_r279584023
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -1183,12 +1183,23 @@ void LpNormCompute(const nnvm::NodeAttrs& attrs,
} else {
small = ReduceAxesShapeImpl(inputs[0].shape_, param.axis, true, false);
}
+
if (param.ord == 1) {
- ReduceAxesComputeImpl<xpu, mshadow_op::sum, true, false, mshadow_op::abs>(
+ if (dmlc::GetEnv("MXNET_ENFORCE_SAFE_ACCUMULATION", false)) {
Review comment:
Add documentation to env_var.md?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
